It is currently 20 Jul 2025, 16:56
   
Text Size

Formal Request Thread

Moderator: CCGHQ Admins

Re: Formal Request Thread

Postby thefiremind » 20 Oct 2013, 15:15

If I'm not missing something, doing this would require to change all the cards that produce counters so that they associate the right counter indexes to the choices, and the query code should be modified whenever a new counter type is introduced. I don't think it's worth for just one card.
Now that you make me think about it, if we ignore the problem of targetting cards in exile, Clockspinning could be coded so that it resembles proliferate, by giving options that only distinguish between any good counter or any bad counter. But even with this, I think there would be problems with time counters: a time counter is bad on your suspended cards (you want to get them unsuspended fast) and good on your vanishing permanents... so... let's give up, shall we? :lol:
< Former DotP 2012/2013/2014 modder >
Currently busy with life...
User avatar
thefiremind
Programmer
 
Posts: 3515
Joined: 07 Nov 2011, 10:55
Has thanked: 118 times
Been thanked: 722 times

Re: Formal Request Thread

Postby jacque » 20 Oct 2013, 15:16

thefiremind wrote:Have you ever wondered what GetCountersType and GetBestOrWorstCounterType return?
Not til what you told me what they do hehehe...

RiiakShiNal wrote:However, making the menu is fairly difficult.
I have a very good feeling with the examples you have given, I'll give this approach a try...
Learn making your own cards today!!!

Click on Image if a post/reply helped you.

I stitch old cards together to make new ones...

~ Jacque, the confused
jacque
 
Posts: 217
Joined: 07 Jun 2013, 20:11
Has thanked: 26 times
Been thanked: 44 times

Re: Formal Request Thread

Postby RiiakShiNal » 20 Oct 2013, 15:45

thefiremind wrote:If I'm not missing something, doing this would require to change all the cards that produce counters so that they associate the right counter indexes to the choices, and the query code should be modified whenever a new counter type is introduced. I don't think it's worth for just one card.
No, the cards that produce counters won't change at all. They already add/count/remove counters using the MTG() functions and/or getting their types from GetCountersType(). The idea is for any card that needs to choose a counter type that it defines it's own relationship table (in a data chest so it can be accessed across actions) by then using that table to figure out which counter types relate to which names. The order of which record refers to which name is only important to the card building the menu. Think of it like this:
Code: Select all
--------------------
|+1/+1   | 0|-13754|
|-1/-1   | 1| 45657|
...
|Divinity|13|195672|
...
--------------------
The first element here is the friendly counter type, the second is the data chest index we assign to that type (only thing that matters here is that it is consistent for the entirety of the Choose Counter Type code, it could be completely different for a different card), and the third element is the value from GetCountersType() for the textual type (which should always be consistent across cards). As long as people don't start defining "Time" counters as "Timer", "My_Time_Counter", "Suspend_Counter", "Vanishing_Counter", or the like then there should be no issues there. Those this method obviously won't work with custom counter types, but as long as gatherer is searched for all valid counter types you can cover all official types.

First action defines the table, second action checks the card for types and builds the menu referencing the table that was built (paging if necessary), third action gets the index from the multiple choice compares with the indexes used for the multiple choice in how they relate to the built table getting the counter type from the table. Now you can either use the type then or store it for use in later action(s).

This is quite possible just time consuming to get all the logic right.

thefiremind wrote:Now that you make me think about it, if we ignore the problem of targetting cards in exile, Clockspinning could be coded so that it resembles proliferate, by giving options that only distinguish between any good counter or any bad counter. But even with this, I think there would be problems with time counters: a time counter is bad on your suspended cards (you want to get them unsuspended fast) and good on your vanishing permanents... so... let's give up, shall we? :lol:
Actually you could look at the zone it is in and adjust accordingly if you wanted to account for that. How many counter types are even possible in ZONE_EXILE? Not many.
RiiakShiNal
Programmer
 
Posts: 2188
Joined: 16 May 2011, 21:37
Has thanked: 75 times
Been thanked: 497 times

Re: Formal Request Thread

Postby drleg3nd » 20 Oct 2013, 18:49

thefiremind wrote:
drleg3nd wrote:thx TFM, was looking at post so is this the scry code you are referring too ?
No, that's sumomole's. My code can be found on my copies of Mystic Speculation and Cryptic Annelid, and the only parameter (on Resolution1) is the scry count.
if it won't be too much trouble, can you or anyone that have any of these cards paste code here ? i am using my portable hdd to save my xmls and i dont seem to have your latest update on here and i can't access storage websites like mediafire at work. thx
drleg3nd
 
Posts: 528
Joined: 14 May 2012, 20:05
Has thanked: 5 times
Been thanked: 30 times

Re: Formal Request Thread

Postby thefiremind » 20 Oct 2013, 19:03

RiiakShiNal wrote:the third element is the value from GetCountersType() for the textual type (which should always be consistent across cards).
OK, I got it. When I wrote the previous post there was something that didn't seem right to me, but now that I understood the idea I can't even remember exactly what it was. :lol:

drleg3nd wrote:if it won't be too much trouble, can you or anyone that have any of these cards paste code here ? i am using my portable hdd to save my xmls and i dont seem to have your latest update on here and i can't access storage websites like mediafire at work. thx
If I post the card code you would still need the LOL file with the scry functions. If I post the LOL file with the scry functions you would still need the LOL file with the constants. And that should be all, but maybe I'm forgetting another dependence... can't you just wait till you can access the links? By the way, my latest update will be exactly 1 month old tomorrow, it's not like you had no time to get it... :mrgreen:
< Former DotP 2012/2013/2014 modder >
Currently busy with life...
User avatar
thefiremind
Programmer
 
Posts: 3515
Joined: 07 Nov 2011, 10:55
Has thanked: 118 times
Been thanked: 722 times

Re: Formal Request Thread

Postby drleg3nd » 20 Oct 2013, 19:19

thefiremind wrote:
RiiakShiNal wrote:the third element is the value from GetCountersType() for the textual type (which should always be consistent across cards).
OK, I got it. When I wrote the previous post there was something that didn't seem right to me, but now that I understood the idea I can't even remember exactly what it was. :lol:

drleg3nd wrote:if it won't be too much trouble, can you or anyone that have any of these cards paste code here ? i am using my portable hdd to save my xmls and i dont seem to have your latest update on here and i can't access storage websites like mediafire at work. thx
If I post the card code you would still need the LOL file with the scry functions. If I post the LOL file with the scry functions you would still need the LOL file with the constants. And that should be all, but maybe I'm forgetting another dependence... can't you just wait till you can access the links? By the way, my latest update will be exactly 1 month old tomorrow, it's not like you had no time to get it... :mrgreen:
lol, no i downloaded on my pc already i just wanted code to update all my scry cards so when i get home i can just move to game.
drleg3nd
 
Posts: 528
Joined: 14 May 2012, 20:05
Has thanked: 5 times
Been thanked: 30 times

Re: Formal Request Thread

Postby RiiakShiNal » 20 Oct 2013, 20:10

drleg3nd wrote:if it won't be too much trouble, can you or anyone that have any of these cards paste code here ? i am using my portable hdd to save my xmls and i dont seem to have your latest update on here and i can't access storage websites like mediafire at work. thx
:shock: I'm surprised that they don't mind you modding at work. :shock:
RiiakShiNal
Programmer
 
Posts: 2188
Joined: 16 May 2011, 21:37
Has thanked: 75 times
Been thanked: 497 times

Re: Formal Request Thread

Postby drleg3nd » 20 Oct 2013, 20:42

RiiakShiNal wrote: :shock: I'm surprised that they don't mind you modding at work. :shock:
lol they can't mind if they don't know what im doing :lol:
drleg3nd
 
Posts: 528
Joined: 14 May 2012, 20:05
Has thanked: 5 times
Been thanked: 30 times

Re: Formal Request Thread

Postby drleg3nd » 21 Oct 2013, 22:00

forum is pretty quiet today,so... im gonna request a card :D
NYLEA'S DISCIPLE | Open
Code: Select all
<TRIGGERED_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[When Nylea’s Disciple enters the battlefield, you gain life equal to your devotion to green.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Quand la Disciple de Nyléa arrive sur le champ de bataille, vous gagnez un nombre de points de vie égal à votre dévotion au vert.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Cuando la Discípula de Nylea entre al campo de batalla, ganas vidas igual a tu devoción al verde.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Wenn die Schülerin der Nylea ins Spiel kommt, erhältst du so viele Lebenspunkte dazu, wie deine Hingabe zu Grün beträgt.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Quando la Discepola di Nylea entra nel campo di battaglia, guadagni punti vita pari alla tua devozione al verde.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[ナイレアの信奉者が戦場に出たとき、あなたはあなたの緑への信心に等しい点数のライフを得る。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[닐리아의 사도가 전장에 들어올 때, 당신은 당신의 녹색 신앙심만큼의 생명점을 얻는다.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Когда Послушница Нилеи выходит на поле битвы, вы получаете количество жизней, равное вашей Преданности зеленому.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Quando Discípulo de Niléia entra no campo de batalha, você ganha uma quantidade de pontos de vida igual a sua devoção ao verde.]]></LOCALISED_TEXT>
  </TRIGGERED_ABILITY>
drleg3nd
 
Posts: 528
Joined: 14 May 2012, 20:05
Has thanked: 5 times
Been thanked: 30 times

Re: Formal Request Thread

Postby sumomole » 22 Oct 2013, 02:32

drleg3nd wrote:forum is pretty quiet today,so... im gonna request a card :D
It's in my mod, I remember.
User avatar
sumomole
Programmer
 
Posts: 611
Joined: 07 Jun 2011, 08:34
Has thanked: 51 times
Been thanked: 234 times

Re: Formal Request Thread

Postby RiiakShiNal » 22 Oct 2013, 02:44

sumomole wrote:
drleg3nd wrote:forum is pretty quiet today,so... im gonna request a card :D
It's in my mod, I remember.
Would you look at that, sumomole is so on top of things that he is fulfilling requests before their even requested. :lol:
RiiakShiNal
Programmer
 
Posts: 2188
Joined: 16 May 2011, 21:37
Has thanked: 75 times
Been thanked: 497 times

Re: Formal Request Thread

Postby drleg3nd » 22 Oct 2013, 20:35

I'm curious..can the new commandeer cards be used in constructed standard decks ? i find the new "doubling season" card interesting to put in
drleg3nd
 
Posts: 528
Joined: 14 May 2012, 20:05
Has thanked: 5 times
Been thanked: 30 times

Re: Formal Request Thread

Postby ZebraGum » 22 Oct 2013, 21:29

Has Hero's Downfall been made yet? Out of all the mods I have here none of that card yet, mabye it doesnt work right with the Planeswalkers?
ZebraGum
 
Posts: 5
Joined: 13 Oct 2013, 06:53
Has thanked: 0 time
Been thanked: 0 time

Re: Formal Request Thread

Postby MC Brodie » 22 Oct 2013, 22:04

If thefiremind can be trusted, this should work (it would work for planeswalkers and won't crash the game if someone doesn't have the PLW mod installed):

Hero's Downfall | Open
Code: Select all
<?xml version='1.0' encoding='UTF-8'?>
<CARD_V2 ExportVersion="1">
  <FILENAME text="HEROS_DOWNFALL_867373575" />
  <CARDNAME text="HEROS_DOWNFALL" />
  <TITLE>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Hero’s Downfall]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Chute du héros]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[La caída del héroe]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Des Helden Untergang]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Caduta dell’Eroe]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[英雄の破滅]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[영웅의 몰락]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Падение Героя]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Queda do Herói]]></LOCALISED_TEXT>
  </TITLE>
  <MULTIVERSEID value="867373575" />
  <ARTID value="867373575" />
  <ARTIST name="Ryan Pancoast" />
  <CASTING_COST cost="{1}{B}{B}" />
  <FLAVOURTEXT>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Destiny exalts a chosen few, but even heroes break.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Rares sont les élus du destin, mais même les héros peuvent chuter.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[El destino engrandece a unos pocos elegidos, pero incluso los héroes pueden caer.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Das Schicksal erhöht einige Auserkorene, doch auch Helden können brechen.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Il destino esalta pochi eletti, ma persino gli eroi possono crollare.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[運命は選ばれた少数の者を讃えるが、英雄とていずれ倒される時が来る。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[운명의 선택을 받은 소수만이 영웅이 될 수 있다. 하지만 영웅조차 무너질 때가 있다.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Судьба возвышает лишь немногих избранных, но даже герой может потерпеть поражение.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[O destino exalta uns poucos escolhidos, mas até mesmo os heróis caem.]]></LOCALISED_TEXT>
  </FLAVOURTEXT>
  <TYPE metaname="Instant" />
  <EXPANSION value="THS" />
  <RARITY metaname="R" />
  <SPELL_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Destroy target creature or planeswalker.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Détruisez la créature ciblée ou le planeswalker ciblé.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Destruye la criatura o planeswalker objetivo.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Zerstöre eine Kreatur oder einen Planeswalker deiner Wahl.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Distruggi una creatura o un planeswalker bersaglio.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[クリーチャー1体かプレインズウォーカー1体を対象とし、それを破壊する。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[생물이나 플레인즈워커 한 개를 목표로 정한다. 그 지속물을 파괴한다.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Уничтожьте целевое существо или planeswalker-а.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Destrua a criatura ou planeswalker alvo.]]></LOCALISED_TEXT>
   <SFX text="TARGET_BLADE_PLAY" />
   <TARGET tag="CARD_QUERY_CHOOSE_CREATURE_TO_DESTROY" definition="0" compartment="0" count="1" />
    <TARGET_DEFINITION id="0">
      local filter = ClearFilter()
      filter:Set_Or()
      filter:Add(FE_TYPE, OP_IS, CARD_TYPE_CREATURE)
      if PLW_FilterNameSet ~= nil then
         PLW_FilterNameSet(filter, "PLANESWALKERS", true)
      else
         filter:Add(FE_TYPE, OP_IS, CARD_TYPE_PLANESWALKER)
      end
    </TARGET_DEFINITION>
   <RESOLUTION_TIME_ACTION>
      local target = EffectDC():Get_Targets(0):Get_CardPtr(0)
      if target ~= nil then   
         target:Destroy() 
      end
    </RESOLUTION_TIME_ACTION>
   <AI_SIMPLIFIED_TARGETING compartment="0" hint="HINT_ENEMY_ONLY" />
  </SPELL_ABILITY>
  <SEALED_HEURISTICS is_removal="1" />
  <SEALED_HEURISTICS score_modifier="1450" />
  <AI_AVAILABILITY type="in_response" response_source="1" />
  <AI_AVAILABILITY window_step="begin_combat" window_turn="their_turn" type="window" />
  <AI_AVAILABILITY window_step="declare_attackers" window_turn="their_turn" type="window" />
  <AI_AVAILABILITY window_step="main_1" window_turn="my_turn" type="window" />
  <AI_AVAILABILITY window_step="declare_blockers" type="window" />
  <AI_AVAILABILITY window_step="end_of_turn" type="window" />
  <AI_AVAILABILITY type="in_response" response_source="1" response_target="1" />
  <AI_BASE_SCORE score="1200" zone="ZONE_HAND" />
</CARD_V2>
-----------------------------------------------------------------------
Song of the Day: 46 and 2 (cover)
MC Brodie
 
Posts: 310
Joined: 01 Jun 2013, 00:10
Has thanked: 44 times
Been thanked: 34 times

Re: Formal Request Thread

Postby thefiremind » 22 Oct 2013, 22:41

drleg3nd wrote:I'm curious..can the new commandeer cards be used in constructed standard decks ? i find the new "doubling season" card interesting to put in
Trick Jarrett wrote:There are going to be, in total, 51 new cards legal in Eternal formats (Vintage and Legacy) but they are not legal in Standard, Block Constructed, or Modern.
My opinion is that you shouldn't really care about the format when making decks for DotP. :wink:
< Former DotP 2012/2013/2014 modder >
Currently busy with life...
User avatar
thefiremind
Programmer
 
Posts: 3515
Joined: 07 Nov 2011, 10:55
Has thanked: 118 times
Been thanked: 722 times

PreviousNext

Return to 2014

Who is online

Users browsing this forum: No registered users and 7 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 7 users online :: 0 registered, 0 hidden and 7 guests (based on users active over the past 10 minutes)
Most users ever online was 7303 on 15 Jul 2025, 20:46

Users browsing this forum: No registered users and 7 guests

Login Form