It is currently 13 Aug 2025, 21:38
   
Text Size

SVN Bug Reports

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Re: SVN Bug Reports

Postby friarsol » 21 Dec 2010, 17:11

Right, for now I'm just going to filter out his own cards and we can work on a way to implement AI considerations when Life Gain is a SubAbility.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: SVN Bug Reports

Postby Corwin72 » 21 Dec 2010, 17:16

Build 4514
I have a larger quest file. 448K
I am getting Java Heap Space errors when trying to go to the shop or deck editor.
Any ideas on how to get working again?
User avatar
Corwin72
 
Posts: 793
Joined: 15 Sep 2009, 13:26
Location: Grayson, Ga
Has thanked: 25 times
Been thanked: 9 times

Re: SVN Bug Reports

Postby Rob Cashwalker » 21 Dec 2010, 18:27

corwin- LQ or HQ pics?
Sell off any cards you have more than 4-of?
The Force will be with you, Always.
User avatar
Rob Cashwalker
Programmer
 
Posts: 2167
Joined: 09 Sep 2008, 15:09
Location: New York
Has thanked: 5 times
Been thanked: 40 times

Re: SVN Bug Reports

Postby SoulStorm » 21 Dec 2010, 19:06

My quest file is approaching 10MB and runs fine, though the card shop takes a while to load. Selling cards is also very slow. I'm still waiting for an auto-sell feature. I'm also using high quality pictures. I actually tried switching to low quality pictures to see if it would speed things up a bit, but it didn't seem to make a difference. I'm using Vista 64 for whatever that is worth.
SoulStorm
 
Posts: 423
Joined: 24 Jun 2010, 22:48
Has thanked: 16 times
Been thanked: 11 times

Re: SVN Bug Reports

Postby Corwin72 » 21 Dec 2010, 20:24

LQ picks.
I do a pretty good job of paring the cards down to 5 or less.
I have 4 or 5 60 card decks in the file.
Attachments
questData.rar
(82.01 KiB) Downloaded 350 times
User avatar
Corwin72
 
Posts: 793
Joined: 15 Sep 2009, 13:26
Location: Grayson, Ga
Has thanked: 25 times
Been thanked: 9 times

Re: SVN Bug Reports

Postby friarsol » 21 Dec 2010, 21:14

Corwin72 wrote:LQ picks.
I do a pretty good job of paring the cards down to 5 or less.
I have 4 or 5 60 card decks in the file.
Corwin, 172k credits? Max life? I'm assuming you have Max everything else. But you've only played 43 games.

I was able to load your deck editor after about 5 minutes on my machine. It looks like you have 8900 cards which is pretty ridiculous.

I'd recommend you dial down your quest.prefs file. Since it seems like the issue here is purely the volume of cards being loaded into the Deck Editor.

For scalability, we should start moving from creating cards on runtime of the editor to just grabbing base information. I think this was one of the main points why Rob wanted to have an Oracle text field. That way in the Deck Editor we could just grab Name, Cost, Types, PT, Rarity for the Table, and Card Detail Panel can use these plus the Oracle Text to fill in the card. The picture would load the same as before.

Maybe after the holidays I'll take a look at what would be needed to get Oracle text grabbed by the Python scripts.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: SVN Bug Reports

Postby Corwin72 » 21 Dec 2010, 21:25

What I did was create a new build and just add the quest file.
No pictures.
I went in and deleted 2 of the decks.
I have been using the standard pref file for a while. It has only been an issue for for a day or so. Could an update to Java cause this?
User avatar
Corwin72
 
Posts: 793
Joined: 15 Sep 2009, 13:26
Location: Grayson, Ga
Has thanked: 25 times
Been thanked: 9 times

Re: SVN Bug Reports

Postby friarsol » 21 Dec 2010, 21:37

Corwin72 wrote:What I did was create a new build and just add the quest file.
No pictures.
I went in and deleted 2 of the decks.
I have been using the standard pref file for a while. It has only been an issue for for a day or so. Could an update to Java cause this?
Do you know what the last build you had was? It felt like to me that it had more to do with the accumulated cards than any amount of decks built. Or any recent update for that matter.

I guess it's possible that an update to Java caused it by reducing the heap to smaller than the necessary size it would need for loading all of these objects into memory. Or you just have more programs open now than usually that are hogging all the memory.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: SVN Bug Reports

Postby Corwin72 » 21 Dec 2010, 22:03

Hmm,
I don't think my machine is working any harder now than usual.
When I checked my Java I did not have the runtime parameter of -Xmx500m for 1.6.0_22. I did have it for the other versions.
I updated Java and sold all my blue cards and deleted 2 decks and it seems to be working faster.
I wish that there was a way to freeplay quest mode so that the decks did not require cards to be owned to play them.I would also like to keep my decks outside of the questData file.
User avatar
Corwin72
 
Posts: 793
Joined: 15 Sep 2009, 13:26
Location: Grayson, Ga
Has thanked: 25 times
Been thanked: 9 times

Re: SVN Bug Reports

Postby Chris H. » 22 Dec 2010, 01:18

Using rev 4535 I just noticed that the computer will not tap a Blood Crypt and I assume the other Ravinca Dual Lands for mana. I can tap my own Blood Crypt for mana.
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: SVN Bug Reports

Postby Chris H. » 22 Dec 2010, 01:21

Corwin72 wrote:I would also like to keep my decks outside of the questData file.
`
The quest mode deck editor will allow you to export one of your quest decks as a .deck file. Import this into the constructed mode deck editor and save. You will then have to open the .deck file in a text editor and change the deck type to constructed to be able to use it.
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: SVN Bug Reports

Postby friarsol » 22 Dec 2010, 02:19

Chris H. wrote:Using rev 4535 I just noticed that the computer will not tap a Blood Crypt and I assume the other Ravinca Dual Lands for mana. I can tap my own Blood Crypt for mana.
Yea that was my fault. I only tested half of a fix for not letting the human tap the AI's land.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: SVN Bug Reports

Postby Corwin72 » 22 Dec 2010, 13:29

The reason that I wanted them out of the questData file is to shrink the size of that file. I like to keep around a lot of decks but the only way I can do this is to export them and delete. It just makes them harder to access. Perhaps if I could Import a deck even if I did not own all of the cards and I could play with that deck. Just an idea.
User avatar
Corwin72
 
Posts: 793
Joined: 15 Sep 2009, 13:26
Location: Grayson, Ga
Has thanked: 25 times
Been thanked: 9 times

Re: SVN Bug Reports

Postby Chris H. » 22 Dec 2010, 13:52

Corwin72 wrote:Perhaps if I could Import a deck even if I did not own all of the cards and I could play with that deck. Just an idea.
`
I think that it would be worthwhile to perform an experiment with a new questData file and see if you can import a deck with cards that are not included in the original card pool. :wink:
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: SVN Bug Reports

Postby Corwin72 » 22 Dec 2010, 14:08

You are a clever man and I would like to buy you a sandwich.

Edit:
Why is my new questdata file only 8K? Usually when I create a new deck it adds 40-50K to a quest data file. I just imported 8 decks and the questdata file is 8k total.
User avatar
Corwin72
 
Posts: 793
Joined: 15 Sep 2009, 13:26
Location: Grayson, Ga
Has thanked: 25 times
Been thanked: 9 times

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 5 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 5 users online :: 0 registered, 0 hidden and 5 guests (based on users active over the past 10 minutes)
Most users ever online was 7303 on 15 Jul 2025, 20:46

Users browsing this forum: No registered users and 5 guests

Login Form