SVN Bug Reports
Post MTG Forge Related Programming Questions Here
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: SVN Bug Reports
by Chris H. » 22 Feb 2011, 00:09
`Chris H. wrote:`
I believe that this one is my fault.![]()
I will take care of the 18 cards that share the same problem.
OK, I just fixed Deep Analysis and tested it, so I think that I am ready for the other 17.

-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: SVN Bug Reports
by Replika » 22 Feb 2011, 13:03
r6699
Krosan Tusker is missing a .Self at ValidCard$ and isn't optional.
Soul Warden, Soul's Attendant and Essence Warden could use a PlayMain1:TRUE to make the AI cast them before other creature spells.
Aurochs counts all other attacking creatures instead of just other attacking Aurochs creatures. X:Count$Valid Aurochs.attacking+Other should do the trick (at least my self-written Aurochs Herd counts correctly with that).
The pump effect is slightly wrong from another point of view: The creatures get pumped right after being declared as attackers instad of putting a trigger on the stack.
Krosan Tusker is missing a .Self at ValidCard$ and isn't optional.
Soul Warden, Soul's Attendant and Essence Warden could use a PlayMain1:TRUE to make the AI cast them before other creature spells.
Aurochs counts all other attacking creatures instead of just other attacking Aurochs creatures. X:Count$Valid Aurochs.attacking+Other should do the trick (at least my self-written Aurochs Herd counts correctly with that).
The pump effect is slightly wrong from another point of view: The creatures get pumped right after being declared as attackers instad of putting a trigger on the stack.
Re: SVN Bug Reports
by slapshot5 » 22 Feb 2011, 14:47
Krosan Tusker and Aurochs are now fixed in SVN.Replika wrote:r6699
Krosan Tusker is missing a .Self at ValidCard$ and isn't optional.
Aurochs counts all other attacking creatures instead of just other attacking Aurochs creatures. X:Count$Valid Aurochs.attacking+Other should do the trick (at least my self-written Aurochs Herd counts correctly with that).
The pump effect is slightly wrong from another point of view: The creatures get pumped right after being declared as attackers instad of putting a trigger on the stack.
-slapshot5
- slapshot5
- Programmer
- Posts: 1391
- Joined: 03 Jan 2010, 17:47
- Location: Mac OS X
- Has thanked: 25 times
- Been thanked: 68 times
Re: SVN Bug Reports
by Chris H. » 22 Feb 2011, 16:14
1 ) I fixed the Flashback ability Deep Reconnaissance and in play testing I noticed a bug. The AI was able to cast this spell with no land in the library without any errors.
I cast this spell with no land in my library and the window displaying the CARDNAME + "Looking at Library" window appears with no lands listed. I could not find anywhere to click to remove this window and had to force quit the forge app.
2) While fixing these broken Flashback cards I have noticed that the AI rarely uses it's mana base to activate a Flashback card that is located in it's graveyard. I have seen the AI do it once or twice so far, it just does not happen very often.
I cast this spell with no land in my library and the window displaying the CARDNAME + "Looking at Library" window appears with no lands listed. I could not find anywhere to click to remove this window and had to force quit the forge app.
2) While fixing these broken Flashback cards I have noticed that the AI rarely uses it's mana base to activate a Flashback card that is located in it's graveyard. I have seen the AI do it once or twice so far, it just does not happen very often.
-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: SVN Bug Reports
by Corwin72 » 22 Feb 2011, 16:30
r6699
AI just played Identity Crisis against me and nothing happened.
AI just played Identity Crisis against me and nothing happened.
-
Corwin72 - Posts: 793
- Joined: 15 Sep 2009, 13:26
- Location: Grayson, Ga
- Has thanked: 25 times
- Been thanked: 9 times
Re: SVN Bug Reports
by friarsol » 22 Feb 2011, 16:52
I'll take care of 1. Apparently a missed edge case where no cards are in the searched zone.Chris H. wrote:1 ) I fixed the Flashback ability Deep Reconnaissance and in play testing I noticed a bug. The AI was able to cast this spell with no land in the library without any errors.
I cast this spell with no land in my library and the window displaying the CARDNAME + "Looking at Library" window appears with no lands listed. I could not find anywhere to click to remove this window and had to force quit the forge app.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: SVN Bug Reports
by slapshot5 » 22 Feb 2011, 17:40
I don't think Identity Crisis is scriptable. It was converted in r6625. Probably needs to be reverted.Corwin72 wrote:r6699
AI just played Identity Crisis against me and nothing happened.
-slapshot5
- slapshot5
- Programmer
- Posts: 1391
- Joined: 03 Jan 2010, 17:47
- Location: Mac OS X
- Has thanked: 25 times
- Been thanked: 68 times
Re: SVN Bug Reports
by srecko » 22 Feb 2011, 23:56
Same thing here. For me it doesn't work on 02/19 and 02/14 version (with files from viewtopic.php?f=26&t=4029. Freezes somewhere around second boosterCorwin72 wrote:Build 6561
Still trying to complete a draft.
This time I did not include my Pics folder when creating a new build.
This screen shot is after 19 cards were drafted. My task manager shows that forge is using 310 megs of ram and using between 48 and 50% of the process. This is the second machine that I have tried to complete a draft.
Is anyone else having this problem?
Edit:
Tried a draft using the 2/19/2011 build. Success..
Tried a draft using the cube rarity files and it worked too.
Trying an SVN build now.
Regular draft rarity files worked but the cube froze me at 19 cards.
- srecko
- Posts: 9
- Joined: 25 Sep 2010, 11:25
- Has thanked: 0 time
- Been thanked: 0 time
Re: SVN Bug Reports
by Hellfish » 23 Feb 2011, 12:03
Could someone better versed in Python take a look at the PerSetTracking script? It really doesn't get along with Python 3.2. (I only noticed because of a recent computer reinstall)
EDIT: Seems none of our scripts get along with python 3.2. Maybe I'm better off downgrading.
EDIT: Seems none of our scripts get along with python 3.2. Maybe I'm better off downgrading.
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
-
Hellfish - Programmer
- Posts: 1297
- Joined: 07 Jun 2009, 10:41
- Location: South of the Pumphouse
- Has thanked: 110 times
- Been thanked: 169 times
Re: SVN Bug Reports
by Chris H. » 23 Feb 2011, 16:14
`friarsol wrote:AI just returned two Absorbs with a single Mnemonic Wall. etbReturnTgt must be buggy, we should convert the 15 or so cards over to Triggers.
Done.
-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: SVN Bug Reports
by jeffwadsworth » 23 Feb 2011, 17:15
I just retested Identity Crisis and it worked perfectly fine. The AI is now out of the loop on it.slapshot5 wrote:I don't think Identity Crisis is scriptable. It was converted in r6625. Probably needs to be reverted.Corwin72 wrote:r6699
AI just played Identity Crisis against me and nothing happened.
-slapshot5
- jeffwadsworth
- Super Tester Elite
- Posts: 1172
- Joined: 20 Oct 2010, 04:47
- Location: USA
- Has thanked: 287 times
- Been thanked: 70 times
Re: SVN Bug Reports
by slapshot5 » 23 Feb 2011, 17:23
I just tested too. Works fine. Stupid computer.jeffwadsworth wrote:I just retested Identity Crisis and it worked perfectly fine. The AI is now out of the loop on it.slapshot5 wrote:I don't think Identity Crisis is scriptable. It was converted in r6625. Probably needs to be reverted.Corwin72 wrote:r6699
AI just played Identity Crisis against me and nothing happened.
-slapshot5
Edit: Whoops. I targeted myself, and my cards disappeared, but so did all the computer's cards in hand.
-slapshot5
Last edited by slapshot5 on 23 Feb 2011, 17:42, edited 1 time in total.
- slapshot5
- Programmer
- Posts: 1391
- Joined: 03 Jan 2010, 17:47
- Location: Mac OS X
- Has thanked: 25 times
- Been thanked: 68 times
Re: SVN Bug Reports
by friarsol » 23 Feb 2011, 17:29
I'm not sure how you tested, but Identity Crisis doesn't work right now, I just looked at the code and it doesn't consider targeting at all. I just cast it with a full hand and my cards were removed along with the AIs.
This is part of http://code.google.com/p/cardforge/issues/detail?id=111 issue
This is part of http://code.google.com/p/cardforge/issues/detail?id=111 issue
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: SVN Bug Reports
by jeffwadsworth » 23 Feb 2011, 17:49
Okay, I will revert it back to the original code. Thanks.
- jeffwadsworth
- Super Tester Elite
- Posts: 1172
- Joined: 20 Oct 2010, 04:47
- Location: USA
- Has thanked: 287 times
- Been thanked: 70 times
Who is online
Users browsing this forum: No registered users and 7 guests