It is currently 15 Sep 2025, 14:55
   
Text Size

Card Contributions

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Re: Card Contributions

Postby Sloth » 03 Sep 2011, 13:25

Innistrad cards can be claimed here: http://www.slightlymagic.net/wiki/Forge_Upcoming

Just add the name in alphabetic order.
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Card Contributions

Postby friarsol » 16 Sep 2011, 02:20

Here's a few cards that I was expecting to see from the Cost changes but haven't yet:

Urborg Panther
Angel's Herald
Behemoth's Herald
Demon's Herald
Dragon's Herald
Sphinx's Herald

I'm not sure which of the Heralds have the corresponding Fetch card for.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Card Contributions

Postby friarsol » 23 Sep 2011, 18:04

I just added a bunch of cards to Weatherlight on the Scriptables Wiki:

http://www.slightlymagic.net/wiki/Forge ... atherlight
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Card Contributions

Postby friarsol » 29 Sep 2011, 02:48

Since clearly there's been lots of demand for it, here are some more Scriptables from Visions:
http://www.slightlymagic.net/wiki/Forge ... es#Visions
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Card Contributions

Postby friarsol » 01 Oct 2011, 02:55

I'm sure this will be more useful after the glitter of Innistrad fades, so I've added a bunch more cards into the scriptables section on the Wiki. If even a portion of the few Sets I've added are done we can get up to 70% across the board. I may try to do a few of the Alliances ones since I know those are tougher.

http://www.slightlymagic.net/wiki/Forge ... able_Cards
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Card Contributions

Postby Sloth » 01 Oct 2011, 19:24

I tried to script Eater of the Dead and stumbled upon a problem:

| Open
Code: Select all
Name:Eater of the Dead
ManaCost:4 B
Types:Creature Horror
Text:no text
PT:3/4
A:AB$ ChangeZone | Cost$ 0 | Origin$ Graveyard | Destination$ Exile | ValidTgts$ Creature | SubAbility$ DBUntap | ConditionPresent$ Card.Self+tapped | SpellDescription$ If CARDNAME is tapped, exile target creature card from a graveyard and untap CARDNAME.
SVar:DBUntap:DB$Untap | ConditionPresent$ Card.Self+tapped | Defined$ Self
SVar:Rarity:Rare
SVar:Picture:http://www.wizards.com/global/images/magic/general/eater_of_the_dead.jpg
End
When I activate his ability while he is untapped the ability will not resolve (which is correct), but the stack still says one ability to resolve and the game can't be continued.
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Card Contributions

Postby slapshot5 » 01 Oct 2011, 19:52

Sloth wrote:When I activate his ability while he is untapped the ability will not resolve (which is correct), but the stack still says one ability to resolve and the game can't be continued.
I stumbled upon something similar to this when scripting something else. Never looked into it.

However, I suspect the problem may be in AbilityFactory.resolve():

If the conditionals fail, the following never gets called:

Code: Select all
AllZone.getStack().finishResolving(...)
I would start there. No debugging for me today. Big sports day in Wisconsin!

-slapshot5
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

Re: Card Contributions

Postby Sloth » 01 Oct 2011, 20:29

slapshot5 wrote:However, I suspect the problem may be in AbilityFactory.resolve():

If the conditionals fail, the following never gets called:

Code: Select all
AllZone.getStack().finishResolving(...)
I would start there. No debugging for me today. Big sports day in Wisconsin!

-slapshot5
Your analysis was exact. And I wrote this code myself... :oops:
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Card Contributions

Postby jeffwadsworth » 07 Oct 2011, 23:21

friarsol wrote:Here's a few cards that I was expecting to see from the Cost changes but haven't yet:

Urborg Panther
Angel's Herald
Behemoth's Herald
Demon's Herald
Dragon's Herald
Sphinx's Herald

I'm not sure which of the Heralds have the corresponding Fetch card for.
These are done in script now. But. Angel's Herald needs Empyrial Archangel to be added first. Perhaps one of you wizards can add her.
Demon's Herald needs Prince of Thralls (needs non-mana unlesscost done).
jeffwadsworth
Super Tester Elite
 
Posts: 1172
Joined: 20 Oct 2010, 04:47
Location: USA
Has thanked: 287 times
Been thanked: 70 times

Re: Card Contributions

Postby moomarc » 28 Oct 2011, 13:05

In the quest to have all token types represented in Forge I added my first card: Volrath's Laboratory (r11516/7). Only 23 to go...
-Marc
User avatar
moomarc
Pixel Commander
 
Posts: 2091
Joined: 04 Jun 2010, 15:22
Location: Johannesburg, South Africa
Has thanked: 371 times
Been thanked: 372 times

Re: Card Contributions

Postby moomarc » 28 Oct 2011, 14:02

r11518: Another one bites the dust :mrgreen: Spirit Mirror is done now too. I've tested and if two Spirit Mirrors are out and both trigger because there's no Refections at the beginning of your upkeep, both triggers will go on the stack but only the first will resolve (which is correct according to the official rulings). =D> Only 22 to go!

Edit: Thought I'd add the code for quick review here too seeing as I'm new to the scripting side.
Code: Select all
Name:Spirit Mirror
ManaCost:2 W W
Types:Enchantment
Text:no text
T:Mode$ Phase | Phase$ Upkeep | ValidPlayer$ You | TriggerZones$ Battlefield | IsPresent$ Reflection | PresentCompare$ EQ0 | Execute$ TrigToken | TriggerDescription$ At the beginning of your upkeep, if there are no Reflection tokens on the battlefield, put a 2/2 white Reflection creature token onto the battlefield.
SVar:TrigToken:AB$Token | Cost$ 0 | TokenAmount$ 1 | TokenName$ Reflection | TokenTypes$ Creature,Reflection | TokenOwner$ You | TokenColors$ White | TokenPower$ 2 | TokenToughness$ 2
SVar:BuffedBy:Reflection.YouDontCtrl
A:AB$ Destroy | Cost$ 0 | ValidTgts$ Reflection | TgtPrompt$ Select target Reflection | SpellDescription$ Destroy target Reflection.
SVar:Rarity:Rare
SVar:Picture:http://www.wizards.com/global/images/magic/general/spirit_mirror.jpg
SetInfo:TMP|Rare|http://magiccards.info/scans/en/tp/260.jpg
Oracle:At the beginning of your upkeep, if there are no Reflection tokens on the battlefield, put a 2/2 white Reflection creature token onto the battlefield./n{0}: Destroy target Reflection.
End
Only bit I'm not sure of is the SVar:BuffedBy:Reflection. Its based mostly on Sarcomancy which has a similar upkeep trigger and has SVar:BuffedBy:Zombie, so I figured it was either needed by the trigger or for AI hinting. If its not necessary (or worse, likely to have a negative effect) let me know and I'll remove it.
Last edited by moomarc on 28 Oct 2011, 14:34, edited 1 time in total.
-Marc
User avatar
moomarc
Pixel Commander
 
Posts: 2091
Joined: 04 Jun 2010, 15:22
Location: Johannesburg, South Africa
Has thanked: 371 times
Been thanked: 372 times

Re: Card Contributions

Postby friarsol » 28 Oct 2011, 14:23

Spirit Mirror will reek havoc against a Changeling deck. Others should chime in, since I don't know how BuffedBy works exactly, but I'd say it should be BuffedBy:Reflection.YouDontCtrl so the Spirit Mirror comes in before combat, and then starts destroying Reflections like crazy.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Card Contributions

Postby moomarc » 28 Oct 2011, 14:28

friarsol wrote:Spirit Mirror will reek havoc against a Changeling deck. Others should chime in, since I don't know how BuffedBy works exactly, but I'd say it should be BuffedBy:Reflection.YouDontCtrl so the Spirit Mirror comes in before combat, and then starts destroying Reflections like crazy.
Sounds excellent. I'll make the change. (I hadn't even realized that I'd scripted a powerful card :shock: Too busy trying to get token creating cards done. :lol: I even tested with changelings to make sure everything was working properly, but never quite registered its potential)

Edit: Script updated (r11519). Also updated script in previous post.
-Marc
User avatar
moomarc
Pixel Commander
 
Posts: 2091
Joined: 04 Jun 2010, 15:22
Location: Johannesburg, South Africa
Has thanked: 371 times
Been thanked: 372 times

Re: Card Contributions

Postby Sloth » 28 Oct 2011, 14:43

moomarc wrote:Sounds excellent. I'll make the change. (I hadn't even realized that I'd scripted a powerful card :shock: Too busy trying to get token creating cards done. :lol: I even tested with changelings to make sure everything was working properly, but never quite registered its potential)

Edit: Script updated (r11519). Also updated script in previous post.
Spirit Mirror is a nice card. The SVar BuffedBy will tell the AI to play Reflection cards he does not control during Main 1, which is a little pointless. SVar:PlayMain1:TRUE may be considered, but is not really needed.
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Card Contributions

Postby moomarc » 28 Oct 2011, 16:42

Sloth wrote:
moomarc wrote:Sounds excellent. I'll make the change. (I hadn't even realized that I'd scripted a powerful card :shock: Too busy trying to get token creating cards done. :lol: I even tested with changelings to make sure everything was working properly, but never quite registered its potential)

Edit: Script updated (r11519). Also updated script in previous post.
Spirit Mirror is a nice card. The SVar BuffedBy will tell the AI to play Reflection cards he does not control during Main 1, which is a little pointless. SVar:PlayMain1:TRUE may be considered, but is not really needed.
Now I'm not sure what to do. Should I just remove BuffedBy line completely or replace it or leave as is? Probably better for one of the pros to just put the finishing touches on it, so I'm leaving as is and you can just fix that line. :oops:
-Marc
User avatar
moomarc
Pixel Commander
 
Posts: 2091
Joined: 04 Jun 2010, 15:22
Location: Johannesburg, South Africa
Has thanked: 371 times
Been thanked: 372 times

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 49 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 49 users online :: 0 registered, 0 hidden and 49 guests (based on users active over the past 10 minutes)
Most users ever online was 7967 on 09 Sep 2025, 23:08

Users browsing this forum: No registered users and 49 guests

Login Form