Card Contributions
Post MTG Forge Related Programming Questions Here
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Card Contributions
by Sloth » 03 Sep 2011, 13:25
Innistrad cards can be claimed here: http://www.slightlymagic.net/wiki/Forge_Upcoming
Just add the name in alphabetic order.
Just add the name in alphabetic order.
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Card Contributions
by friarsol » 16 Sep 2011, 02:20
Here's a few cards that I was expecting to see from the Cost changes but haven't yet:
Urborg Panther
Angel's Herald
Behemoth's Herald
Demon's Herald
Dragon's Herald
Sphinx's Herald
I'm not sure which of the Heralds have the corresponding Fetch card for.
Urborg Panther
Angel's Herald
Behemoth's Herald
Demon's Herald
Dragon's Herald
Sphinx's Herald
I'm not sure which of the Heralds have the corresponding Fetch card for.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Card Contributions
by friarsol » 23 Sep 2011, 18:04
I just added a bunch of cards to Weatherlight on the Scriptables Wiki:
http://www.slightlymagic.net/wiki/Forge ... atherlight
http://www.slightlymagic.net/wiki/Forge ... atherlight
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Card Contributions
by friarsol » 29 Sep 2011, 02:48
Since clearly there's been lots of demand for it, here are some more Scriptables from Visions:
http://www.slightlymagic.net/wiki/Forge ... es#Visions
http://www.slightlymagic.net/wiki/Forge ... es#Visions
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Card Contributions
by friarsol » 01 Oct 2011, 02:55
I'm sure this will be more useful after the glitter of Innistrad fades, so I've added a bunch more cards into the scriptables section on the Wiki. If even a portion of the few Sets I've added are done we can get up to 70% across the board. I may try to do a few of the Alliances ones since I know those are tougher.
http://www.slightlymagic.net/wiki/Forge ... able_Cards
http://www.slightlymagic.net/wiki/Forge ... able_Cards
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Card Contributions
by Sloth » 01 Oct 2011, 19:24
I tried to script Eater of the Dead and stumbled upon a problem:
- | Open
- Code: Select all
Name:Eater of the Dead
ManaCost:4 B
Types:Creature Horror
Text:no text
PT:3/4
A:AB$ ChangeZone | Cost$ 0 | Origin$ Graveyard | Destination$ Exile | ValidTgts$ Creature | SubAbility$ DBUntap | ConditionPresent$ Card.Self+tapped | SpellDescription$ If CARDNAME is tapped, exile target creature card from a graveyard and untap CARDNAME.
SVar:DBUntap:DB$Untap | ConditionPresent$ Card.Self+tapped | Defined$ Self
SVar:Rarity:Rare
SVar:Picture:http://www.wizards.com/global/images/magic/general/eater_of_the_dead.jpg
End
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Card Contributions
by slapshot5 » 01 Oct 2011, 19:52
I stumbled upon something similar to this when scripting something else. Never looked into it.Sloth wrote:When I activate his ability while he is untapped the ability will not resolve (which is correct), but the stack still says one ability to resolve and the game can't be continued.
However, I suspect the problem may be in AbilityFactory.resolve():
If the conditionals fail, the following never gets called:
- Code: Select all
AllZone.getStack().finishResolving(...)
-slapshot5
- slapshot5
- Programmer
- Posts: 1391
- Joined: 03 Jan 2010, 17:47
- Location: Mac OS X
- Has thanked: 25 times
- Been thanked: 68 times
Re: Card Contributions
by Sloth » 01 Oct 2011, 20:29
Your analysis was exact. And I wrote this code myself...slapshot5 wrote:However, I suspect the problem may be in AbilityFactory.resolve():
If the conditionals fail, the following never gets called:I would start there. No debugging for me today. Big sports day in Wisconsin!
- Code: Select all
AllZone.getStack().finishResolving(...)
-slapshot5

-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Card Contributions
by jeffwadsworth » 07 Oct 2011, 23:21
These are done in script now. But. Angel's Herald needs Empyrial Archangel to be added first. Perhaps one of you wizards can add her.friarsol wrote:Here's a few cards that I was expecting to see from the Cost changes but haven't yet:
Urborg Panther
Angel's Herald
Behemoth's Herald
Demon's Herald
Dragon's Herald
Sphinx's Herald
I'm not sure which of the Heralds have the corresponding Fetch card for.
Demon's Herald needs Prince of Thralls (needs non-mana unlesscost done).
- jeffwadsworth
- Super Tester Elite
- Posts: 1172
- Joined: 20 Oct 2010, 04:47
- Location: USA
- Has thanked: 287 times
- Been thanked: 70 times
Re: Card Contributions
by moomarc » 28 Oct 2011, 13:05
In the quest to have all token types represented in Forge I added my first card: Volrath's Laboratory (r11516/7). Only 23 to go...
-Marc
-
moomarc - Pixel Commander
- Posts: 2091
- Joined: 04 Jun 2010, 15:22
- Location: Johannesburg, South Africa
- Has thanked: 371 times
- Been thanked: 372 times
Re: Card Contributions
by moomarc » 28 Oct 2011, 14:02
r11518: Another one bites the dust
Spirit Mirror is done now too. I've tested and if two Spirit Mirrors are out and both trigger because there's no Refections at the beginning of your upkeep, both triggers will go on the stack but only the first will resolve (which is correct according to the official rulings).
Only 22 to go!
Edit: Thought I'd add the code for quick review here too seeing as I'm new to the scripting side.


Edit: Thought I'd add the code for quick review here too seeing as I'm new to the scripting side.
- Code: Select all
Name:Spirit Mirror
ManaCost:2 W W
Types:Enchantment
Text:no text
T:Mode$ Phase | Phase$ Upkeep | ValidPlayer$ You | TriggerZones$ Battlefield | IsPresent$ Reflection | PresentCompare$ EQ0 | Execute$ TrigToken | TriggerDescription$ At the beginning of your upkeep, if there are no Reflection tokens on the battlefield, put a 2/2 white Reflection creature token onto the battlefield.
SVar:TrigToken:AB$Token | Cost$ 0 | TokenAmount$ 1 | TokenName$ Reflection | TokenTypes$ Creature,Reflection | TokenOwner$ You | TokenColors$ White | TokenPower$ 2 | TokenToughness$ 2
SVar:BuffedBy:Reflection.YouDontCtrl
A:AB$ Destroy | Cost$ 0 | ValidTgts$ Reflection | TgtPrompt$ Select target Reflection | SpellDescription$ Destroy target Reflection.
SVar:Rarity:Rare
SVar:Picture:http://www.wizards.com/global/images/magic/general/spirit_mirror.jpg
SetInfo:TMP|Rare|http://magiccards.info/scans/en/tp/260.jpg
Oracle:At the beginning of your upkeep, if there are no Reflection tokens on the battlefield, put a 2/2 white Reflection creature token onto the battlefield./n{0}: Destroy target Reflection.
End
Last edited by moomarc on 28 Oct 2011, 14:34, edited 1 time in total.
-Marc
-
moomarc - Pixel Commander
- Posts: 2091
- Joined: 04 Jun 2010, 15:22
- Location: Johannesburg, South Africa
- Has thanked: 371 times
- Been thanked: 372 times
Re: Card Contributions
by friarsol » 28 Oct 2011, 14:23
Spirit Mirror will reek havoc against a Changeling deck. Others should chime in, since I don't know how BuffedBy works exactly, but I'd say it should be BuffedBy:Reflection.YouDontCtrl so the Spirit Mirror comes in before combat, and then starts destroying Reflections like crazy.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Card Contributions
by moomarc » 28 Oct 2011, 14:28
Sounds excellent. I'll make the change. (I hadn't even realized that I'd scripted a powerful cardfriarsol wrote:Spirit Mirror will reek havoc against a Changeling deck. Others should chime in, since I don't know how BuffedBy works exactly, but I'd say it should be BuffedBy:Reflection.YouDontCtrl so the Spirit Mirror comes in before combat, and then starts destroying Reflections like crazy.


Edit: Script updated (r11519). Also updated script in previous post.
-Marc
-
moomarc - Pixel Commander
- Posts: 2091
- Joined: 04 Jun 2010, 15:22
- Location: Johannesburg, South Africa
- Has thanked: 371 times
- Been thanked: 372 times
Re: Card Contributions
by Sloth » 28 Oct 2011, 14:43
Spirit Mirror is a nice card. The SVar BuffedBy will tell the AI to play Reflection cards he does not control during Main 1, which is a little pointless. SVar:PlayMain1:TRUE may be considered, but is not really needed.moomarc wrote:Sounds excellent. I'll make the change. (I hadn't even realized that I'd scripted a powerful cardToo busy trying to get token creating cards done.
I even tested with changelings to make sure everything was working properly, but never quite registered its potential)
Edit: Script updated (r11519). Also updated script in previous post.
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Card Contributions
by moomarc » 28 Oct 2011, 16:42
Now I'm not sure what to do. Should I just remove BuffedBy line completely or replace it or leave as is? Probably better for one of the pros to just put the finishing touches on it, so I'm leaving as is and you can just fix that line.Sloth wrote:Spirit Mirror is a nice card. The SVar BuffedBy will tell the AI to play Reflection cards he does not control during Main 1, which is a little pointless. SVar:PlayMain1:TRUE may be considered, but is not really needed.moomarc wrote:Sounds excellent. I'll make the change. (I hadn't even realized that I'd scripted a powerful cardToo busy trying to get token creating cards done.
I even tested with changelings to make sure everything was working properly, but never quite registered its potential)
Edit: Script updated (r11519). Also updated script in previous post.

-Marc
-
moomarc - Pixel Commander
- Posts: 2091
- Joined: 04 Jun 2010, 15:22
- Location: Johannesburg, South Africa
- Has thanked: 371 times
- Been thanked: 372 times
Who is online
Users browsing this forum: No registered users and 70 guests